search

Vonage / vonage-cli

Vonage CLI tool.
Apache License 2.0
17 stars 13 forks source link

Update init.ts #87

Closed anshuman35 closed 1 year ago

dragonmantank commented 1 year ago

@anshuman35 Can you provide some additional context for this PR? It looks like it's attempting to also use the data passed in to write to a folder, but data should be the data we write to the file.

@manchuck On a separate note, looks like writeFile() doesn't actually use the data parameter passed in. I'm guess it was meant to be a general function but we just hard-coded it to write the creds to a file. We should fix that.

manchuck commented 1 year ago

@dragonmantank Yea, I noticed that it was not using data as well and removed it here: https://github.com/Vonage/vonage-cli/pull/78/commits/13c85ba40b3c9f7e4778856b45a645a6ba26a925#diff-5cf742199f3d9ea7da40eacd3ee87166e50ec1d643c464c963151d976a0ca203L16

I plan on doing an overall on writing files which would address this as well

manchuck commented 1 year ago

Closing this PR as there is no context for what this PR is trying to address.