search

Vonage / vonage-dotnet-sdk

Vonage REST API client for .NET, written in C#. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
https://developer.vonage.com/
Apache License 2.0
105 stars 82 forks source link

ConversationAction does not support custom event url #561

Closed MarcusKohnert closed 5 months ago

MarcusKohnert commented 9 months ago

Describe the bug The class ConversationAction provides the two properties EventMethod and EventUrl to customize the webhook where events should be received. If those values are set they are not respected during runtime and according to Vonage support team the Conversation action does not support an eventUrl.

Original text by Vonage support team: 'The Conversation action does not support an eventUrl for the events of a conversation, only for the recording. You can find further information in our documentation: https://developer.vonage.com/en/voice/voice-api/ncco-reference#conversation

For inbound calls, you will need to specify the eventUrl at the application level, and can override this for specific actions. For outbound calls, you can override the application eventUrl in the API request.'

Support request: #2410685

Environment(please complete the following information):

Tr00d commented 9 months ago

Hi @MarcusKohnert,

Thanks for letting me know - I'll have a look at that. Based on my understanding, those properties should not be there in the first place. I need to ensure they're not used elsewhere, or at least that this action isn't used for more than it should. On my side, this is clearly a breaking change as I'm modifying a public contract. I guess you can expect that to be fixed in the upcoming major release 7.0.0.

I'll keep you posted.

Tr00d commented 6 months ago

Hi @MarcusKohnert,

I wanted to share some feedback. This breaking change is available in the latest version v7.0.0-alpha. Being an alpha, the package is still subject to potential problems. I do expect a final version very soon.

Tr00d commented 5 months ago

Hi,

v7.0.0 is finally out, and this problem has been addressed.

Don't hesitate to share some feedback :smile:

MarcusKohnert commented 5 months ago

Hi @Tr00d,

I'm a bit surprised to still find EventMethod and EventUrl on class ConversationAction.

Didn't the change make it to v7? 🤔

Tr00d commented 5 months ago

Hi @MarcusKohnert,

You're absolutely right... I need to investigate how this happened. Apologies for that :disappointed:

I'll find a solution to release it. I guess I can deprecate/remove the current v7.X.X version, and make a new one the normal breaking upgrade. Anyway, I'll manage.

Tr00d commented 5 months ago

@MarcusKohnert,

After investigation, I lost track of that change. It wasn't included in the alpha version, despite my message. My bet is the branch got deleted before being merged. It doesn't look great...

Anyway, I released v7.2.0 this morning and unlisted prior v7.1.0 and v7.0.0 as this change was documented in the migration guide. I know I'm "bending" the laws of semantic versioning but it seems to be the past of least resistance at the moment.

Sorry about all that fuss.

MarcusKohnert commented 5 months ago

No worries. 🤗 I can confirm, that the properties are now removed. ✅