Closed lshep311 closed 4 years ago
:exclamation: No coverage uploaded for pull request base (
master@9bdb748
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #28 +/- ##
======================================
Coverage ? 31%
======================================
Files ? 16
Lines ? 316
Branches ? 0
======================================
Hits ? 100
Misses ? 212
Partials ? 4
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9bdb748...92d3f79. Read the comment docs.
We love pull requests but in this case we won't be able to accept. We can't add pin code support to the library since it's only available to a very small number of customers and will cause errors for everyone else :( If you have ideas for supporting both use cases, I'd be very happy to hear them.
Add the pin code parameter to the StartVerificationRequest - this parameter is currently leveraged by us in production for our use cases Added test for verify.go in a similar format to existing tests.