search

Vonage / vonage-go-sdk

A lightweight library to help Go users everywhere integrate with the Vonage APIs. Issues and PRs all really welcome!!
https://vonage.github.io/vonage-go-sdk/
Apache License 2.0
51 stars 32 forks source link

StartVerificationRequest pin code #28

Closed lshep311 closed 4 years ago

lshep311 commented 4 years ago

Add the pin code parameter to the StartVerificationRequest - this parameter is currently leveraged by us in production for our use cases Added test for verify.go in a similar format to existing tests.

codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9bdb748). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             master   #28   +/-   ##
======================================
  Coverage          ?   31%           
======================================
  Files             ?    16           
  Lines             ?   316           
  Branches          ?     0           
======================================
  Hits              ?   100           
  Misses            ?   212           
  Partials          ?     4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9bdb748...92d3f79. Read the comment docs.

lornajane commented 4 years ago

We love pull requests but in this case we won't be able to accept. We can't add pin code support to the library since it's only available to a very small number of customers and will cause errors for everyone else :( If you have ideas for supporting both use cases, I'd be very happy to hear them.