search

Vonage / vonage-go-sdk

A lightweight library to help Go users everywhere integrate with the Vonage APIs. Issues and PRs all really welcome!!
https://vonage.github.io/vonage-go-sdk/
Apache License 2.0
51 stars 32 forks source link

Add Custom JSON Marshalling to NCCO #39

Closed lornajane closed 3 years ago

lornajane commented 3 years ago

When we make an API call, we can just pass in the NCCO as an object and the library handles everything for us. When returning an NCCO response, the user needs to call GetActions() themselves. As a helper feature, make the NCCO do this by itself when it is JSON-Marshalled.

avinashdhinwa commented 3 years ago

@lornajane Can I work on this?

lornajane commented 3 years ago

Please go ahead, thanks :)

lornajane commented 3 years ago

Merged and released in v0.12.1

ruskibenya commented 3 years ago

@avinashdhinwa, do you mind if we shout you out for this awesome contribution on twitter? This is you?

avinashdhinwa commented 3 years ago

@avinashdhinwa, do you mind if we shout you out for this awesome contribution on twitter? This is you?

@ruskibenya Yes, this is me. I would be more than happy for this.