search

Vonage / vonage-go-sdk

A lightweight library to help Go users everywhere integrate with the Vonage APIs. Issues and PRs all really welcome!!
https://vonage.github.io/vonage-go-sdk/
Apache License 2.0
51 stars 32 forks source link

Added New function to nexmo.go, NewClient kept for backwards compat #4

Closed Strum355 closed 5 years ago

Strum355 commented 5 years ago

As was mentioned in TODO.md New simply calls NewClient

codecov-io commented 5 years ago

Codecov Report

Merging #4 into master will increase coverage by <1%. The diff coverage is 66%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #4    +/-   ##
=====================================
+ Coverage      26%   26%   +<1%     
=====================================
  Files          16    16            
  Lines         314   316     +2     
=====================================
+ Hits           82    84     +2     
  Misses        228   228            
  Partials        4     4
Impacted Files Coverage Δ
calls.go 0% <ø> (ø) :arrow_up:
application.go 0% <ø> (ø) :arrow_up:
developer_account_pricing.go 0% <0%> (ø) :arrow_up:
nexmo.go 87% <100%> (+1%) :arrow_up:
sms_base.go 71% <0%> (ø) :arrow_up:
insight.go 62% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1b4edd...fa58b63. Read the comment docs.

judy2k commented 5 years ago

Nice little improvement - thanks!