search

Vonage / vonage-go-sdk

A lightweight library to help Go users everywhere integrate with the Vonage APIs. Issues and PRs all really welcome!!
https://vonage.github.io/vonage-go-sdk/
Apache License 2.0
51 stars 32 forks source link

Ncco now implements marshaller interface, no need to call `GetActions` for marshalling Ncco #43

Closed avinashdhinwa closed 3 years ago

avinashdhinwa commented 3 years ago

issue: #39

avinashdhinwa commented 3 years ago

@lornajane I've made an edit in internal/voice/model_create_call_request_ncco.go as well but I read in contribution guidelines that any change to files in internal should be avoided, so from where can I generate this file again. In other words, where do I need to change the spec to generate this file.

lornajane commented 3 years ago

Thanks so much for this! Just a couple of things I think we need before it is ready to merge. As you have spotted, we don't make changes in the internal/ directory so please leave this unchanged. The code in this library (e.g. ncco.Ncco) wraps the generated code so it doesn't make sense for them to depend on one another.

I would also appreciate it if you would update the docs/examples as well to show the new usage.

avinashdhinwa commented 3 years ago

The code in this library (e.g. ncco.Ncco) wraps the generated code so it doesn't make sense for them to depend on one another.

Makes sense.

I would also appreciate it if you would update the docs/examples as well to show the new usage.

Sure, will do.

avinashdhinwa commented 3 years ago

@lornajane I've updated the docs after finding where marshalling of ncco was done (in docs), please let me know if I need to document anything else. Also, I've reverted the changes to internal/ package.

avinashdhinwa commented 3 years ago

Thanks @lornajane for helping me out with this PR, it was my first pr on an open source project. Thanks again :)