Replace voice name with voice style in NCCO

Vonage / vonage-go-sdk

A lightweight library to help Go users everywhere integrate with the Vonage APIs. Issues and PRs all really welcome!!

https://vonage.github.io/vonage-go-sdk/

Apache License 2.0

51 stars 32 forks source link

Replace voice name with voice style in NCCO #44

Closed thearavind closed 1 year ago

thearavind commented 3 years ago

Fixes #41

Checklist:

[x] I have read the contributor's guide.
[x] I linked an issue in the previous section
[x] I was assigned the linked issue
[x] I have tested the change to the best of my ability
[x] My change requires a changes to the documentation.

In this PR I have added support for voice styles and language fields without removing the existing voice name field. They both will co-exist

thearavind commented 3 years ago

Hi @lornajane I will try to add some unit test cases in the next commit, Also I'll regenerate the code into the internal folder using the updated OpenAPI spec files after https://github.com/Nexmo/api-specification/pull/367 gets merged

lornajane commented 3 years ago

That PR is causing some internal discussion so I have added the hacktoberfest-accepted label to this PR to make sure you get the credit for your work! I'll merge or update this once the change to the API description has been made.