search

Vonage / vonage-go-sdk

A lightweight library to help Go users everywhere integrate with the Vonage APIs. Issues and PRs all really welcome!!
https://vonage.github.io/vonage-go-sdk/
Apache License 2.0
51 stars 32 forks source link

Added 'enums' as per TODO #5

Closed Strum355 closed 5 years ago

Strum355 commented 5 years ago

I may have missed some, but I got hopefully the all that I could find in the docs

codecov-io commented 5 years ago

Codecov Report

Merging #5 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master    #5   +/-   ##
====================================
  Coverage      26%   26%           
====================================
  Files          16    16           
  Lines         314   314           
====================================
  Hits           82    82           
  Misses        228   228           
  Partials        4     4
Impacted Files Coverage Δ
structs.go 100% <ø> (ø) :arrow_up:
sms_base.go 71% <ø> (ø) :arrow_up:
insight.go 62% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13abe96...169557a. Read the comment docs.

Strum355 commented 5 years ago

Hey, would it be possible to get this and https://github.com/nexmo-community/nexmo-go/pull/5 merged? :) im going through my forked repos and cleaning them up atm

judy2k commented 5 years ago

I've incorporated your changes into #13 - thank you so much for your contribution!

Strum355 commented 5 years ago

Thanks for the merge :) i must've mistyped my last comment, as ive also got a pending PR at #4
Edit: just saw you were working on that just now, my bad