Vonage / vonage-java-sdk

Vonage Server SDK for Java. API support for SMS, Messages, Voice, Text-to-Speech, Numbers, Verify (2FA), Video and more.

https://developer.vonage.com/en/home

Apache License 2.0

95 stars 119 forks source link

Message product's spelling is wrong for Redact API #237

Closed sharif-malik closed 5 years ago

sharif-malik commented 5 years ago

After talking to support team, I got to know that message should messages in the RedactRequest.Product enum.

sharif-malik commented 5 years ago

https://github.com/Nexmo/nexmo-java/blob/master/src/main/java/com/nexmo/client/redact/RedactRequest.java#L90

sharif-malik commented 5 years ago

Here is the documentation from NEXMO(https://developer.nexmo.com/api/redact), which is expecting messages

sharif-malik commented 5 years ago

238 Here is the PR to fix this issue

sharif-malik commented 5 years ago

@cr0wst Please review this Issue and followed by PR #238

sharif-malik commented 5 years ago

Backward compatibility, actually failing my tests when I do integration tests.

sharif-malik commented 5 years ago

@cr0wst , it should be message instead of messages

sharif-malik commented 5 years ago

Shall I create another PR for the same. Because currently my tests is picking from text so it always pick MESSAGE instead of MESSAGES

sharif-malik commented 5 years ago

@cr0wst Here is the another PR to fix the value of deprecated product name value

sharif-malik commented 5 years ago

Because it fails everytime to pick right product enum

cr0wst commented 5 years ago

We only use this enum for serialization, it's not intended to be used for deserialization at this time.

sharif-malik commented 5 years ago

Yeah, I understand your point. Currently having both enum's value as same is not resilient, I am not able to do integration tests in my project because of deserialisation.

This #240 PR, it will work for all. Isn't it?

cr0wst commented 5 years ago

Added explanation in #240.