Vonage / vonage-java-sdk

Vonage Server SDK for Java. API support for SMS, Messages, Voice, Text-to-Speech, Numbers, Verify (2FA), Video and more.
https://developer.vonage.com/en/home
Apache License 2.0
97 stars 123 forks source link

[blitz] Remove unnecessary references to the "this" keyword #305

Closed yallen011 closed 4 years ago

yallen011 commented 4 years ago

There are several files in the SDK that reference this.variable-name where it is only necessary to reference the variable using just the variable name itself. Below is a list of files that need to be changed.

Instructions

Assign yourself to one of the files listed below by commenting with the name of the file you are going to work on, assign yourself to the PR, then link the PR you create to this issue

Files

andrewtlu commented 4 years ago

I would like to work on VonageClient.java.

ThanoshanMV commented 4 years ago

I would like to work on HttpWrapper.java

WorkInProgress-Development commented 4 years ago

Apologies if I am missing something obvious, but there doesn't seem to be a list of files on this issue.

yallen011 commented 4 years ago

@WorkInProgress-Development sorry, I haven't added them yet. I was still getting some of the Issues setup for Hacktoberfest. But you are more than welcome to go through the repo and if you find one that you want to work on, just comment here so that others will know that file is taken and won't try to submit a PR for the same change.

ThanoshanMV commented 4 years ago

Hi @yallen011 ,

I would like to work on AccountClient.java, PrefixPricingEndpoint.java, PricingEndpoint.java, SecretManagementEndpoint.java, SettingsEndpoint.java, TopUpEndpoint.java

Thank you

Hitesh77 commented 4 years ago

Hi @yallen011

I would like to work in the following classes:

Thanks

poornapragna877 commented 4 years ago

I would like to Work on BasicInsightRequest.java

imabhinavagarwal commented 4 years ago

Hi @yallen011 I would like to work on ApplicationClient.java and ApplicationEndpoint.java Thanks

malakar-soham commented 4 years ago

I would like to work on BinaryMessage.java

WesleyBrenno commented 4 years ago

I would like to work on

herculesherculano commented 4 years ago

I would like to work on:

SanchitaMishra170676 commented 4 years ago

I would like to work on SmsClient.java

malakar-swastik commented 4 years ago

I would like to work on WapPushMessage.java

Prassud commented 4 years ago

I would like to work on below files

Messages.java

Rtc.java

Voice.java

Application.java

Hitesh77 commented 4 years ago

Hi All,

I am contributing to open source for the first and getting a 403(forbidden) error while pushing the code, can anyone please help me out with this.

Thanks in Advance.

imabhinavagarwal commented 4 years ago

Hi @Hitesh77 Have you forked the repo or are you trying to push in main repo? P.S.: You can ask in discord to get faster response. Here is the link https://discord.gg/hacktoberfest

Hitesh77 commented 4 years ago

Hi @imabhinavagarwal,

Thank you so much for your help, I haven't forked the repo but now after fork, I'm not getting a 403 error.

Keenal commented 4 years ago

I'd like to take:

ListApplicationRequest.java

berry120 commented 4 years ago

Hello,

I'd like to take SmsSubmissionResponse.java.

henry398 commented 4 years ago

Hi! I'd like to work on TokenAuthMethod.java

ILGO0413 commented 4 years ago

I'd like to work on: JWTAuthMethod.java VonageUnacceptableAuthException.java ConversionClient.java ConversionEndpoint.java AdvancedInsightRequest.java

ILGO0413 commented 4 years ago

Also fixed remaining files: InsightClient.java StandardInsightRequest.java MessageStatus.java SearchRejectedMessagesRequest.java SmsIdSearchRequest.java

yallen011 commented 4 years ago

@imabhinavagarwal thank you so much for hopping in and helping out with @Hitesh77's question ⭐

daniel-shuy commented 4 years ago

I'll take the remaining:

aryanrawlani28 commented 4 years ago

Hi! I'll take CheckEndpoint.java & CheckResponse.java. Cheers!

Code0987 commented 4 years ago

Hey,

Taking up some extras HttpConfig.java AbstractMethod.java.

Thanks.