Vonage / vonage-java-sdk

Vonage Server SDK for Java. API support for SMS, Messages, Voice, Text-to-Speech, Numbers, Verify (2FA), Video and more.
https://developer.vonage.com/en/home
Apache License 2.0
95 stars 119 forks source link

refactor: Voice API to use DynamicEndpoint #490

Closed SMadani closed 8 months ago

SMadani commented 8 months ago

This is the final PR in the long-running series of refactorings in the SDK to decouple the implementation of endpoints (and their tests) from the underlying Apache HttpClient library. In additional to reimplementing the endpoints, some further deprecations have been made in preparation for a more substantial refactoring - which would include breaking changes - in a future PR / release.

codecov-commenter commented 8 months ago

Codecov Report

Merging #490 (d061496) into main (8cfcf59) will increase coverage by 0.25%. The diff coverage is 94.69%.

@@             Coverage Diff              @@
##               main     #490      +/-   ##
============================================
+ Coverage     93.62%   93.87%   +0.25%     
+ Complexity     2630     2590      -40     
============================================
  Files           393      380      -13     
  Lines          6665     6529     -136     
  Branches        429      431       +2     
============================================
- Hits           6240     6129     -111     
+ Misses          252      226      -26     
- Partials        173      174       +1     
Files Coverage Δ
...ain/java/com/vonage/client/incoming/CallEvent.java 100.00% <100.00%> (+13.33%) :arrow_up:
...in/java/com/vonage/client/incoming/DtmfResult.java 100.00% <ø> (ø)
...in/java/com/vonage/client/incoming/InputEvent.java 100.00% <100.00%> (+16.66%) :arrow_up:
...n/java/com/vonage/client/incoming/NotifyEvent.java 100.00% <100.00%> (ø)
...n/java/com/vonage/client/incoming/RecordEvent.java 100.00% <100.00%> (+16.66%) :arrow_up:
...c/main/java/com/vonage/client/incoming/Result.java 100.00% <ø> (ø)
src/main/java/com/vonage/client/voice/Call.java 99.02% <100.00%> (+1.75%) :arrow_up:
...c/main/java/com/vonage/client/voice/CallEvent.java 100.00% <100.00%> (+11.76%) :arrow_up:
...rc/main/java/com/vonage/client/voice/CallInfo.java 100.00% <100.00%> (+9.43%) :arrow_up:
...ain/java/com/vonage/client/voice/CallInfoPage.java 100.00% <100.00%> (ø)
... and 15 more

... and 1 file with indirect coverage changes