search

Vonage / vonage-java-sdk

Vonage Server SDK for Java. API support for SMS, Messages, Voice, Text-to-Speech, Numbers, Verify (2FA), Video and more.
https://developer.vonage.com/en/home
Apache License 2.0
97 stars 121 forks source link

fix: Call modification & signature verification #498

Closed SMadani closed 10 months ago

SMadani commented 10 months ago

This PR updates the signatures of the newly added call modification methods in VoiceClient to accept a String instead of UUID, for consistency with the rest of the API. It also adds a public verifyRequestSignature method to RequestSigning for MD5 signatures. This was previously removed due to its dependency on HttpServletRequest, but has now been implemented in a manner which works around this.

codecov-commenter commented 10 months ago

Codecov Report

Merging #498 (0cb510e) into main (27f86d1) will increase coverage by 0.02%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #498 +/- ## ============================================ + Coverage 94.63% 94.66% +0.02% - Complexity 2862 2863 +1 ============================================ Files 423 423 Lines 6950 6949 -1 Branches 439 439 ============================================ + Hits 6577 6578 +1 + Misses 202 200 -2 Partials 171 171 ``` | [Files](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage) | Coverage Δ | | |---|---|---| | [...in/java/com/vonage/client/auth/RequestSigning.java](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage#diff-c3JjL21haW4vamF2YS9jb20vdm9uYWdlL2NsaWVudC9hdXRoL1JlcXVlc3RTaWduaW5nLmphdmE=) | `83.51% <100.00%> (+0.18%)` | :arrow_up: | | [...c/main/java/com/vonage/client/voice/CallEvent.java](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage#diff-c3JjL21haW4vamF2YS9jb20vdm9uYWdlL2NsaWVudC92b2ljZS9DYWxsRXZlbnQuamF2YQ==) | `100.00% <ø> (ø)` | | | [...a/com/vonage/client/voice/TransferDestination.java](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage#diff-c3JjL21haW4vamF2YS9jb20vdm9uYWdlL2NsaWVudC92b2ljZS9UcmFuc2ZlckRlc3RpbmF0aW9uLmphdmE=) | `100.00% <ø> (+11.76%)` | :arrow_up: | | [...main/java/com/vonage/client/voice/VoiceClient.java](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage#diff-c3JjL21haW4vamF2YS9jb20vdm9uYWdlL2NsaWVudC92b2ljZS9Wb2ljZUNsaWVudC5qYXZh) | `97.22% <100.00%> (ø)` | |