search

Vonage / vonage-java-sdk

Vonage Server SDK for Java. API support for SMS, Messages, Voice, Text-to-Speech, Numbers, Verify (2FA), Video and more.
https://developer.vonage.com/en/home
Apache License 2.0
97 stars 121 forks source link

feat: Tidy up SMS workflow & add new parameters #509

Closed SMadani closed 8 months ago

SMadani commented 8 months ago

This PR adds Builder pattern to com.vonage.client.verify2.Workflow and some of its subclasses, since the optional parameters list is expected to grow. Namely, the SMS and SIlent Auth workflows now have a Builder. Additionally, SMS workflow has the new entity_id and content_id fields.

codecov-commenter commented 8 months ago

Codecov Report

Merging #509 (00de73d) into main (1b1caa5) will increase coverage by 0.02%. The diff coverage is 98.59%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #509 +/- ## ============================================ + Coverage 95.19% 95.21% +0.02% - Complexity 2874 2895 +21 ============================================ Files 426 427 +1 Lines 6824 6880 +56 Branches 392 393 +1 ============================================ + Hits 6496 6551 +55 - Misses 200 201 +1 Partials 128 128 ``` | [Files](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage) | Coverage Δ | | |---|---|---| | [.../vonage/client/verify2/AbstractNumberWorkflow.java](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage#diff-c3JjL21haW4vamF2YS9jb20vdm9uYWdlL2NsaWVudC92ZXJpZnkyL0Fic3RyYWN0TnVtYmVyV29ya2Zsb3cuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...in/java/com/vonage/client/verify2/SmsWorkflow.java](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage#diff-c3JjL21haW4vamF2YS9jb20vdm9uYWdlL2NsaWVudC92ZXJpZnkyL1Ntc1dvcmtmbG93LmphdmE=) | `100.00% <100.00%> (ø)` | | | [.../java/com/vonage/client/verify2/VoiceWorkflow.java](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage#diff-c3JjL21haW4vamF2YS9jb20vdm9uYWdlL2NsaWVudC92ZXJpZnkyL1ZvaWNlV29ya2Zsb3cuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...onage/client/verify2/WhatsappCodelessWorkflow.java](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage#diff-c3JjL21haW4vamF2YS9jb20vdm9uYWdlL2NsaWVudC92ZXJpZnkyL1doYXRzYXBwQ29kZWxlc3NXb3JrZmxvdy5qYXZh) | `100.00% <100.00%> (ø)` | | | [...va/com/vonage/client/verify2/WhatsappWorkflow.java](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage#diff-c3JjL21haW4vamF2YS9jb20vdm9uYWdlL2NsaWVudC92ZXJpZnkyL1doYXRzYXBwV29ya2Zsb3cuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [.../main/java/com/vonage/client/verify2/Workflow.java](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage#diff-c3JjL21haW4vamF2YS9jb20vdm9uYWdlL2NsaWVudC92ZXJpZnkyL1dvcmtmbG93LmphdmE=) | `100.00% <100.00%> (ø)` | | | [.../com/vonage/client/verify2/SilentAuthWorkflow.java](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage#diff-c3JjL21haW4vamF2YS9jb20vdm9uYWdlL2NsaWVudC92ZXJpZnkyL1NpbGVudEF1dGhXb3JrZmxvdy5qYXZh) | `95.00% <93.33%> (-5.00%)` | :arrow_down: |