search

Vonage / vonage-java-sdk

Vonage Server SDK for Java. API support for SMS, Messages, Voice, Text-to-Speech, Numbers, Verify (2FA), Video and more.
https://developer.vonage.com/en/home
Apache License 2.0
95 stars 119 forks source link

feat: Add missing NCCO fields #510

Closed SMadani closed 6 months ago

SMadani commented 6 months ago

A fair few fields are not present in the NCCO actions in com.vonage.client.voice.ncco. This PR updates them to be consistent with the NCCO reference documentation, along with improved documentation. It also achieves 100% coverage for Voice, since the VoiceResponseException wasn't covered in VoiceClientTest.

codecov-commenter commented 6 months ago

Codecov Report

Merging #510 (7967b67) into main (b5179f6) will increase coverage by 0.11%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #510 +/- ## ============================================ + Coverage 95.21% 95.33% +0.11% - Complexity 2895 2934 +39 ============================================ Files 427 428 +1 Lines 6880 6983 +103 Branches 393 407 +14 ============================================ + Hits 6551 6657 +106 + Misses 201 198 -3 Partials 128 128 ``` | [Files](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage) | Coverage Δ | | |---|---|---| | [...va/com/vonage/client/voice/ncco/ConnectAction.java](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage#diff-c3JjL21haW4vamF2YS9jb20vdm9uYWdlL2NsaWVudC92b2ljZS9uY2NvL0Nvbm5lY3RBY3Rpb24uamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...m/vonage/client/voice/ncco/ConversationAction.java](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage#diff-c3JjL21haW4vamF2YS9jb20vdm9uYWdlL2NsaWVudC92b2ljZS9uY2NvL0NvbnZlcnNhdGlvbkFjdGlvbi5qYXZh) | `100.00% <100.00%> (ø)` | | | [...java/com/vonage/client/voice/ncco/InputAction.java](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage#diff-c3JjL21haW4vamF2YS9jb20vdm9uYWdlL2NsaWVudC92b2ljZS9uY2NvL0lucHV0QWN0aW9uLmphdmE=) | `100.00% <ø> (ø)` | | | [...ava/com/vonage/client/voice/ncco/NotifyAction.java](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage#diff-c3JjL21haW4vamF2YS9jb20vdm9uYWdlL2NsaWVudC92b2ljZS9uY2NvL05vdGlmeUFjdGlvbi5qYXZh) | `100.00% <100.00%> (ø)` | | | [...ava/com/vonage/client/voice/ncco/RecordAction.java](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage#diff-c3JjL21haW4vamF2YS9jb20vdm9uYWdlL2NsaWVudC92b2ljZS9uY2NvL1JlY29yZEFjdGlvbi5qYXZh) | `100.00% <100.00%> (ø)` | | | [...a/com/vonage/client/voice/ncco/SpeechSettings.java](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage#diff-c3JjL21haW4vamF2YS9jb20vdm9uYWdlL2NsaWVudC92b2ljZS9uY2NvL1NwZWVjaFNldHRpbmdzLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...onage/client/voice/ncco/TranscriptionSettings.java](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage#diff-c3JjL21haW4vamF2YS9jb20vdm9uYWdlL2NsaWVudC92b2ljZS9uY2NvL1RyYW5zY3JpcHRpb25TZXR0aW5ncy5qYXZh) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/Vonage/vonage-java-sdk/pull/510/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vonage)