search

Vonage / vonage-media-transformers-samples

Vonage Media Transformers Examples
MIT License
3 stars 1 forks source link

OW-792: Video SDK - Build iOS test app #35

Closed joliveraortega closed 5 months ago

joliveraortega commented 5 months ago

Video SDK - Build iOS test app

joliveraortega commented 5 months ago

there is some changes of NS web in here... lets rebase the branches too.

@gmininberg Branch https://github.com/Vonage/vonage-media-transformers-samples/tree/feature/OW-744 is the source branch here and the one that has to be rebased. That branch is yours (you know we do not like to work in other's branch).

i build up the code there were issues of symbols

I feel you did not followed https://vonage.slack.com/archives/C03STN3QSQ5/p1705505096588189 and used the custom build of the OpenTok XC framework. The one you pull from Cocopoads is 2.27.0 and has nothing about all our changes.

and i left some comments.

Thanks, I will go over them today.

gmininberg commented 5 months ago

lets talk about this PR.

joliveraortega commented 5 months ago

lets talk about this PR.

@gmininberg Review comments during the talk we had are addressed now. Thanks.