applications code snippet: outdated script - Githubissues

Vonage / vonage-node-code-snippets

NodeJS code examples for using Vonage

MIT License

70 stars 78 forks source link

applications code snippet: outdated script #153

Closed porcherface closed 2 months ago

porcherface commented 4 months ago

the updateApplication method does not read the applicationId field, leading to undefined webhook when making the api call

Expected Behavior

return a merged application

Current Behavior

returns error 404 due to missing id in url

Possible Solution

from a quick inspection of the sdk code the module expects an "id" field rather than "applicationId"

Steps to Reproduce

run this with any .env provided by vonage : https://github.com/Vonage/vonage-node-code-snippets/blob/master/applications/update-application.js

Possible Implementation

just namefix

manchuck commented 2 months ago

The snippet has been updated