Vonage / vonage-node-sdk

Vonage API client for Node.js. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
Apache License 2.0
374 stars 178 forks source link

build: cleanup TS build files #704

Closed manchuck closed 1 year ago

manchuck commented 1 year ago

Cleaning up Typescript build files

Description

Having multiple tsconfig.json files makes it difficult to manage the build process. Having one central config file for all the packages helps reduce DRY config options while still allowing finer control over the build process. There are two different files used to allow separation from building and testing.

Motivation and Context

Reduces DRY configs and makes building typescript more manageable

Testing Details

Run tsc --build --verbose and confirm that all typescript files built without errors

Example Output or Screenshots (if appropriate)

Types of changes

Checklist

dragonmantank commented 1 year ago

Just noting, while the codecov does fail, not sure why the unit tests fail saying the Voice is missing a bunch of dependency classes. I just tried locally and the compile step works fine, but it does die on a unit test for @vonage/video (I'm guessing because of a rules change, because this module published fine and we require unit tests to work to publish, and 3.x-wip still works OK locally at least).