Vonage / vonage-node-sdk

Vonage API client for Node.js. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
Apache License 2.0
374 stars 178 forks source link

fix: Allow features to be searched in available numbers #731

Closed dragonmantank closed 1 year ago

dragonmantank commented 1 year ago

Description

Searching for available numbers did not allow searching by feature, so added that. Also added some helper enums for searching to make understanding the options better.

Searching by feature also makes sure that the options are always in the correct order.

Motivation and Context

When working on a demo, I could not search by feature so needed this.

The additional enums make it easier to understand what some of the options are.

The feature sorting also removes the need for the developer to know what order to put the features in, the SDK will re-order them. The developer just needs to chuck the features into an array, everything else is handled.

Testing Details

Unit tests

Example Output or Screenshots (if appropriate)

Types of changes

Checklist