Vonage / vonage-node-sdk

Vonage API client for Node.js. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
Apache License 2.0
374 stars 178 forks source link

fix: Correct our return types when sending SMS #743

Closed dragonmantank closed 1 year ago

dragonmantank commented 1 year ago

Description

Corrects the type definition for the returned SMS responses to match the original declaration. This also adds keys with appropriate deprecation notices to not break existing code.

Motivation and Context

Per #742 , the definitions we provided for the return response did not match the API. Looks like as this was an early module, we never finished cleaning up to make it match.

Testing Details

Unit tests

Example Output or Screenshots (if appropriate)

Types of changes

Checklist