fix: Verify - Added brand to seperate out from Sender ID - Githubissues

Vonage / vonage-node-sdk

Vonage API client for Node.js. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.

Apache License 2.0

374 stars 178 forks source link

fix: Verify - Added brand to seperate out from Sender ID #744

Closed dragonmantank closed 1 year ago

dragonmantank commented 1 year ago

Description

Verify was missing Brand as it was confused with Sender ID, a newer option for some countries

Motivation and Context

Bug fix

Testing Details

Unit tests and manual testing

Example Output or Screenshots (if appropriate)

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.