feat: meetings package - Githubissues

Vonage / vonage-node-sdk

Vonage API client for Node.js. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.

Apache License 2.0

375 stars 178 forks source link

feat: meetings package #788

Closed manchuck closed 1 year ago

manchuck commented 1 year ago

Adding the meetings API

Description

This adds the meetings API calls to the SDK.

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

ziahamza commented 1 year ago

@manchuck whats still left in this PR to wrap up? Would love to see this get merged 🚢

manchuck commented 1 year ago

@ziahamza We have put this release on hold as our internal team is working on changes to the API endpoints, which might not be compatible with the current meetings API specification. Once those changes have been released, we will work on updating the SDK.

codecov-commenter commented 1 year ago

Codecov Report

Merging #788 (2c3ccb3) into 3.x (e50c7cb) will increase coverage by 1.51%. The diff coverage is 97.54%.

@@            Coverage Diff             @@
##              3.x     #788      +/-   ##
==========================================
+ Coverage   80.06%   81.57%   +1.51%     
==========================================
  Files          99      100       +1     
  Lines        1289     1411     +122     
  Branches      257      280      +23     
==========================================
+ Hits         1032     1151     +119     
- Misses        256      259       +3     
  Partials        1        1

Impacted Files	Coverage Δ
packages/meetings/lib/meetings.ts	`97.52% <97.52%> (ø)`
packages/server-client/lib/client.ts	`98.43% <100.00%> (+0.02%)`	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more