Vonage / vonage-node-sdk

Vonage API client for Node.js. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
Apache License 2.0
375 stars 178 forks source link

feat: updating messages to be non breaking #813

Closed manchuck closed 1 year ago

manchuck commented 1 year ago

After having some thought, I figured out how to keep messages from causing a major release.

Description

All older classes/interfaces and types needed have been restored with the proper inheritance setup. All new files added to this PR MUST have @deprecation doc blocks. New classes MUST have a log informing the user to update

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

Checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #813 (2e3189b) into 3.x (f10f9e4) will increase coverage by 1.44%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              3.x     #813      +/-   ##
==========================================
+ Coverage   77.49%   78.94%   +1.44%     
==========================================
  Files          86      104      +18     
  Lines        1133     1211      +78     
  Branches      233      234       +1     
==========================================
+ Hits          878      956      +78     
  Misses        255      255              
Impacted Files Coverage Δ
packages/messages/lib/classes/MMS/Audio.ts 100.00% <100.00%> (ø)
packages/messages/lib/classes/MMS/Image.ts 100.00% <100.00%> (ø)
packages/messages/lib/classes/MMS/Vcard.ts 100.00% <100.00%> (ø)
packages/messages/lib/classes/MMS/Video.ts 100.00% <100.00%> (ø)
packages/messages/lib/classes/Messenger/Audio.ts 100.00% <100.00%> (ø)
packages/messages/lib/classes/Messenger/File.ts 100.00% <100.00%> (ø)
packages/messages/lib/classes/Messenger/Image.ts 100.00% <100.00%> (ø)
packages/messages/lib/classes/Messenger/Text.ts 100.00% <100.00%> (ø)
packages/messages/lib/classes/Messenger/Video.ts 100.00% <100.00%> (ø)
packages/messages/lib/classes/SMS/SMS.ts 100.00% <100.00%> (ø)
... and 9 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more