feat: bring your own passcode

Vonage / vonage-node-sdk

Vonage API client for Node.js. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.

Apache License 2.0

375 stars 178 forks source link

feat: bring your own passcode #816

Closed manchuck closed 1 year ago

manchuck commented 1 year ago

Adding in bring your own passcode for verify v2

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov-commenter commented 1 year ago

Codecov Report

Merging #816 (d998fc0) into 3.x (8ac7c32) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              3.x     #816   +/-   ##
=======================================
  Coverage   78.94%   78.94%           
=======================================
  Files         104      104           
  Lines        1211     1211           
  Branches      234      234           
=======================================
  Hits          956      956           
  Misses        255      255

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more