Vonage / vonage-node-sdk

Vonage API client for Node.js. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
Apache License 2.0
375 stars 178 forks source link

refactor: added custom exceptions when required parameters are missing #821

Closed manchuck closed 1 year ago

manchuck commented 1 year ago

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

Checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #821 (0426557) into 3.x (e3f9ecb) will increase coverage by 0.44%. The diff coverage is 96.55%.

:exclamation: Current head 0426557 differs from pull request most recent head 77fc404. Consider uploading reports for the commit 77fc404 to get more accurate results

@@            Coverage Diff             @@
##              3.x     #821      +/-   ##
==========================================
+ Coverage   78.94%   79.39%   +0.44%     
==========================================
  Files         104       97       -7     
  Lines        1211     1252      +41     
  Branches      234      249      +15     
==========================================
+ Hits          956      994      +38     
- Misses        255      257       +2     
- Partials        0        1       +1     
Impacted Files Coverage Δ
packages/jwt/lib/index.ts 100.00% <ø> (ø)
packages/server-client/lib/transformers.ts 96.00% <ø> (ø)
packages/auth/lib/auth.ts 94.44% <85.71%> (-3.67%) :arrow_down:
packages/auth/lib/errors/InvalidApiKeyError.ts 100.00% <100.00%> (ø)
packages/auth/lib/errors/InvalidApiSecretError.ts 100.00% <100.00%> (ø)
packages/auth/lib/errors/MissingApiKeyError.ts 100.00% <100.00%> (ø)
packages/auth/lib/errors/MissingApiSecretError.ts 100.00% <100.00%> (ø)
...ckages/jwt/lib/errors/invalidApplicationIdError.ts 100.00% <100.00%> (ø)
packages/jwt/lib/errors/invalidPrivateKeyError.ts 100.00% <100.00%> (ø)
...ckages/jwt/lib/errors/missingApplicationIdError.ts 100.00% <100.00%> (ø)
... and 5 more

... and 16 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

manchuck commented 1 year ago

@dragonmantank That was a strange rebase that happened. Either way, some GitFu and PC have been removed