Closed dragonmantank closed 1 year ago
Merging #828 (4380d4c) into 3.x (a9a36c9) will increase coverage by
0.12%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## 3.x #828 +/- ##
==========================================
+ Coverage 79.68% 79.81% +0.12%
==========================================
Files 99 99
Lines 1265 1273 +8
Branches 252 254 +2
==========================================
+ Hits 1008 1016 +8
Misses 256 256
Partials 1 1
Impacted Files | Coverage Δ | |
---|---|---|
packages/video/lib/video.ts | 83.68% <100.00%> (+0.98%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Description
The Dial API does not properly handle blank strings (
''
) versus null values in parameters passed in, so this adds a method and strips the blank strings if they are passed in. This also includes a long overdue whitespace fixRelevant functions are:
intiateSIPCall() stripBlankValues()
Motivation and Context
Bug reported in UAT testing the new SDK versus the old OpenTok SDK
Testing Details
Unit tests
Example Output or Screenshots (if appropriate)
Types of changes
Checklist