Vonage / vonage-node-sdk

Vonage API client for Node.js. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
Apache License 2.0
375 stars 178 forks source link

feat(voice): adding advanced machine detection #835

Closed manchuck closed 1 year ago

manchuck commented 1 year ago

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

Checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #835 (fa8de5a) into 3.x (858b41e) will decrease coverage by 1.47%. The diff coverage is 48.99%.

:exclamation: Current head fa8de5a differs from pull request most recent head 04b14b1. Consider uploading reports for the commit 04b14b1 to get more accurate results

@@            Coverage Diff             @@
##              3.x     #835      +/-   ##
==========================================
- Coverage   83.42%   81.96%   -1.47%     
==========================================
  Files         119      117       -2     
  Lines        1484     1325     -159     
  Branches      282      259      -23     
==========================================
- Hits         1238     1086     -152     
+ Misses        245      238       -7     
  Partials        1        1              
Impacted Files Coverage Δ
packages/voice/lib/classes/NCCO/Record.ts 1.35% <1.35%> (+1.35%) :arrow_up:
packages/voice/lib/classes/NCCO/Connect.ts 2.38% <2.38%> (+2.38%) :arrow_up:
packages/voice/lib/classes/NCCO/Stream.ts 5.55% <5.55%> (+5.55%) :arrow_up:
packages/voice/lib/classes/NCCO/Notify.ts 9.09% <9.09%> (+9.09%) :arrow_up:
packages/voice/lib/classes/NCCO/Talk.ts 60.00% <60.00%> (ø)
packages/voice/lib/classes/NCCO/Conversation.ts 61.76% <61.76%> (ø)
packages/voice/lib/classes/OutboundCall.ts 71.42% <71.42%> (ø)
packages/voice/lib/classes/NCCO/Input.ts 77.77% <77.77%> (ø)
packages/voice/lib/voice.ts 95.45% <95.45%> (ø)
packages/voice/lib/classes/NCCO/NCCOBuilder.ts 100.00% <100.00%> (ø)
... and 21 more

... and 4 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more