Vonage / vonage-node-sdk

Vonage API client for Node.js. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
Apache License 2.0
375 stars 178 forks source link

refactor(voice): cleanup voice package #838

Closed manchuck closed 1 year ago

manchuck commented 1 year ago

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

Checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #838 (29a2f75) into 3.x (e50c7cb) will increase coverage by 1.90%. The diff coverage is 48.99%.

:exclamation: Current head 29a2f75 differs from pull request most recent head f4d7c5b. Consider uploading reports for the commit f4d7c5b to get more accurate results

@@            Coverage Diff             @@
##              3.x     #838      +/-   ##
==========================================
+ Coverage   80.06%   81.96%   +1.90%     
==========================================
  Files          99      117      +18     
  Lines        1289     1325      +36     
  Branches      257      259       +2     
==========================================
+ Hits         1032     1086      +54     
+ Misses        256      238      -18     
  Partials        1        1              
Impacted Files Coverage Δ
packages/voice/lib/classes/NCCO/Record.ts 1.35% <1.35%> (+1.35%) :arrow_up:
packages/voice/lib/classes/NCCO/Connect.ts 2.38% <2.38%> (+2.38%) :arrow_up:
packages/voice/lib/classes/NCCO/Stream.ts 5.55% <5.55%> (+5.55%) :arrow_up:
packages/voice/lib/classes/NCCO/Notify.ts 9.09% <9.09%> (+9.09%) :arrow_up:
packages/voice/lib/classes/NCCO/Talk.ts 60.00% <60.00%> (+30.00%) :arrow_up:
packages/voice/lib/classes/NCCO/Conversation.ts 61.76% <61.76%> (+1.15%) :arrow_up:
packages/voice/lib/classes/OutboundCall.ts 71.42% <71.42%> (+4.76%) :arrow_up:
packages/voice/lib/classes/NCCO/Input.ts 77.77% <77.77%> (+33.33%) :arrow_up:
packages/voice/lib/voice.ts 95.45% <95.45%> (-0.85%) :arrow_down:
packages/voice/lib/classes/NCCO/NCCOBuilder.ts 100.00% <100.00%> (+8.33%) :arrow_up:
... and 21 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more