Closed dragonmantank closed 1 year ago
Some of the NCCO actions had their action property set to undefined because the typehint was set to the value, not the property. This corrects that.
action
This generated invalid NCCOs for these types
Code:
builder.addAction(new Talk("Hello")); builder.addAction( new Stream("https://www.soundhelix.com/examples/mp3/SoundHelix-Song-1.mp3") ); console.log(builder.build());
Output:
[ Talk { action: 'talk', text: 'Hello', bargeIn: undefined, loop: undefined, level: undefined, language: undefined, style: undefined, premium: undefined }, Stream { action: undefined, <--- Invalid action streamUrl: [ 'https://www.soundhelix.com/examples/mp3/SoundHelix-Song-1.mp3' ], level: undefined, bargeIn: undefined, loop: undefined } ]
With #838 this is addressed with an Enum.
Description
Some of the NCCO actions had their
action
property set to undefined because the typehint was set to the value, not the property. This corrects that.Motivation and Context
This generated invalid NCCOs for these types
Testing Details
Example Output or Screenshots (if appropriate)
Code:
Output:
Types of changes
Checklist