Closed dragonmantank closed 11 months ago
Merging #846 (9f5fc1a) into 3.x (8760b0f) will increase coverage by
0.02%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## 3.x #846 +/- ##
==========================================
+ Coverage 83.42% 83.44% +0.02%
==========================================
Files 119 119
Lines 1484 1486 +2
Branches 282 283 +1
==========================================
+ Hits 1238 1240 +2
Misses 245 245
Partials 1 1
Files Changed | Coverage Δ | |
---|---|---|
packages/jwt/lib/jwt.ts | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Description
When passing in a
ttl
to generate a new token, we accidentally leave thettl
parameter in the claims. This is causing a problem with tokens being rejected. Theexp
is calculated properly, but we just leave the additionalttl
claim there due to object unpacking.Motivation and Context
This breaks JWT validation
Testing Details
Added a unit test
Example Output or Screenshots (if appropriate)
Types of changes
Checklist