Vonage / vonage-node-sdk

Vonage API client for Node.js. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
Apache License 2.0
375 stars 178 forks source link

fix: timeout parameter being respected #850

Closed manchuck closed 10 months ago

manchuck commented 10 months ago

resolves #843

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

Checklist

codecov-commenter commented 10 months ago

Codecov Report

Merging #850 (95ae2ba) into 3.x (f04c595) will increase coverage by 0.07%. The diff coverage is 100.00%.

:exclamation: Current head 95ae2ba differs from pull request most recent head 3dcd3fe. Consider uploading reports for the commit 3dcd3fe to get more accurate results

@@            Coverage Diff             @@
##              3.x     #850      +/-   ##
==========================================
+ Coverage   83.42%   83.50%   +0.07%     
==========================================
  Files         119      119              
  Lines        1484     1491       +7     
  Branches      283      284       +1     
==========================================
+ Hits         1238     1245       +7     
  Misses        245      245              
  Partials        1        1              
Files Changed Coverage Δ
packages/vetch/lib/vetch.ts 94.66% <100.00%> (+0.54%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more