refactor(meetings): version is now present in the api path

Vonage / vonage-node-sdk

Vonage API client for Node.js. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.

Apache License 2.0

375 stars 178 forks source link

refactor(meetings): version is now present in the api path #865

Closed manchuck closed 9 months ago

manchuck commented 9 months ago

Also included missing dependancy for proactive connect

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

codecov-commenter commented 9 months ago

Codecov Report

Merging #865 (7345276) into 3.x (e90fe32) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              3.x     #865   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files         121      121           
  Lines        1619     1619           
  Branches      311      311           
=======================================
  Hits         1358     1358           
  Misses        260      260           
  Partials        1        1

Files Changed	Coverage Δ
packages/meetings/lib/meetings.ts	`97.52% <ø> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more