Vonage / vonage-node-sdk

Vonage API client for Node.js. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
Apache License 2.0
375 stars 178 forks source link

refactor: fixing typo in ServiceType enum #867

Closed ajumal-ashraf-dev closed 9 months ago

ajumal-ashraf-dev commented 9 months ago

Description

I have corrected the typo in the enum from "voice," to "voice".

Motivation and Context

There was an extra comma in the enum value causing the REST calls to fail and return a 404 error on requesting pricing for "voice"

Testing Details

Tested in a sample project. Does not affect other areas.

Example Output or Screenshots (if appropriate)

Types of changes

Checklist

ajumal-ashraf-dev commented 9 months ago

@dragonmantank @tommorris @cbetta @benfoxall @mheap Please review the change. Thank you.

manchuck commented 9 months ago

Note to me: Double check your macros when building out enums

codecov-commenter commented 9 months ago

Codecov Report

Merging #867 (517260c) into 3.x (12ec202) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              3.x     #867   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files         121      121           
  Lines        1619     1619           
  Branches      311      311           
=======================================
  Hits         1358     1358           
  Misses        260      260           
  Partials        1        1           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more