Vonage / vonage-node-sdk

Vonage API client for Node.js. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
Apache License 2.0
375 stars 178 forks source link

fix(voice): ncco encoding #906

Closed manchuck closed 5 months ago

manchuck commented 5 months ago

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

Checklist

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (05cbf33) 83.38% compared to head (b6acd55) 83.41%.

:exclamation: Current head b6acd55 differs from pull request most recent head f2bdb27. Consider uploading reports for the commit f2bdb27 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.x #906 +/- ## ========================================== + Coverage 83.38% 83.41% +0.03% ========================================== Files 121 121 Lines 1637 1640 +3 Branches 323 324 +1 ========================================== + Hits 1365 1368 +3 Misses 272 272 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.