Vonage / vonage-php-sdk-core

Vonage REST API client for PHP. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
https://developer.vonage.com/
Apache License 2.0
917 stars 181 forks source link

Remove Pay NCCO #374

Closed SecondeJK closed 1 year ago

SecondeJK commented 1 year ago

This PR removes the Pay NCCO

Description

The Pay-over-phone feature has been removed from the Voice API

Motivation and Context

Keep SDK up to date with Vonage APIs

How Has This Been Tested?

Removed the Pay NCCO test.

Example Output or Screenshots (if appropriate):

Types of changes

Checklist:

codecov-commenter commented 1 year ago

Codecov Report

Merging #374 (280de65) into main (5a2ac50) will decrease coverage by 0.16%. The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #374      +/-   ##
============================================
- Coverage     78.30%   78.14%   -0.16%     
+ Complexity     1817     1786      -31     
============================================
  Files           172      171       -1     
  Lines          4871     4804      -67     
============================================
- Hits           3814     3754      -60     
+ Misses         1057     1050       -7     

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

SecondeJK commented 1 year ago

Opening new PR to deprecate this instead of removing it for semver purposes