Vonage / vonage-php-sdk-core

Vonage REST API client for PHP. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
https://developer.vonage.com/
Apache License 2.0
916 stars 180 forks source link

Remove vonage/nexmo-bridge #399

Closed ankurk91 closed 1 year ago

ankurk91 commented 1 year ago

Fix issue https://github.com/Vonage/vonage-php-sdk-core/issues/398

Description

vonage/nexmo-bridge must be removed

Motivation and Context

It has been around 3 years since it was introduced

How Has This Been Tested?

I believe all of developers has changed their namespace in their code, and if they have not, they can still install this package to keep backward compatibility

Example Output or Screenshots (if appropriate):

Types of changes

Checklist:

SecondeJK commented 1 year ago

This might become a bit of stale PR:

Removing nexmo-bridge is a BC breaking change, which means this can only go in v5.0

We do need to bin it, but it'll take time.

ankurk91 commented 1 year ago

Okay, you can keep the issue opened, meanwhile if someone wants to get rid of this package can update their composer.json like

 "replace": {
    "vonage/nexmo-bridge": "*"
 }   

Then run composer update --lock command