Vonage / vonage-php-sdk-core

Vonage REST API client for PHP. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
https://developer.vonage.com/
Apache License 2.0
916 stars 180 forks source link

Fix small cedilla test + encoding #403

Closed SecondeJK closed 1 year ago

SecondeJK commented 1 year ago

This PR fixes the regex and test for the small cedilla to not be counted as GSM-7

Description

Issue #395 is due to incorrect unicode behaviour. Previously this was dealt with in the old encryption detector which would convert an entire GSM charset to unicode character codes to compare - this in itself had a bug by not treating this particular character as missing from GSM7.

How Has This Been Tested?

The original test for this character was wrong - it's been corrected, and all tests pass.

Types of changes

Checklist: