search

Vonage / vonage-php-sdk-core

Vonage REST API client for PHP. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
https://developer.vonage.com/
Apache License 2.0
916 stars 180 forks source link

Redefine fraud_check rendering #407

Closed SecondeJK closed 1 year ago

SecondeJK commented 1 year ago

Rendering fraud_check on a request will 403 if the Network Unblock API has not been enabled on an account. As this defaults to true, the only condition that should render in the payload for a request is if the developer has explicitly told the SDK to render a false bypass.

codecov-commenter commented 1 year ago

Codecov Report

Merging #407 (a94445f) into main (3c6d784) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #407   +/-   ##
=========================================
  Coverage     77.60%   77.60%           
- Complexity     1961     1962    +1     
=========================================
  Files           191      191           
  Lines          5220     5221    +1     
=========================================
+ Hits           4051     4052    +1     
  Misses         1169     1169
Impacted Files Coverage Δ
src/Verify2/Request/BaseVerifyRequest.php 92.85% <100.00%> (+0.10%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more