Vonage / vonage-php-sdk-core

Vonage REST API client for PHP. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
https://developer.vonage.com/
Apache License 2.0
916 stars 180 forks source link

Typo for behavio(u)r in advanced machine detection implementation #411

Closed giorgio93p closed 1 year ago

giorgio93p commented 1 year ago

Current Behavior

When an NCCO with advanced machine detection is built using this library, it is rejected with a reason (in an event) behavior cannot be empty or NULL. Notice the spelling in the error and in the docs: behavior.

Observe that the code currently https://github.com/Vonage/vonage-php-sdk-core/blob/bb29ae2b9001581a077e09114394f9ce88973828/src/Voice/VoiceObjects/AdvancedMachineDetection.php#L84 outputs the value as behaviour.

Possible Solution

Changing the spelling of behavio(u)r in the code suffices to get rid of the error.

Your Environment

SecondeJK commented 1 year ago

Fixed in #415 To be deployed