Vonage / vonage-php-sdk-core

Vonage REST API client for PHP. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
https://developer.vonage.com/
Apache License 2.0
916 stars 180 forks source link

Fix getRecording for Voice, URL Override #413

Closed SecondeJK closed 1 year ago

SecondeJK commented 1 year ago

This contains an important bug fix for Voice

Description

The original release of getRecording() in the Voice client would still contain the baseURL and baseUri inherited from the APIResource configuration.

getRecording() needs the edge case ability to take any URL it's given (from the voice webhook containing a download URL) and apply Vonage credentials to it.

Motivation and Context

The Vonage Helpdesk project has identified this as a major bug. We also want to phase out users using the old base Vonage client get() method as Auth is all handled within configurable APIResource objects.

How Has This Been Tested?

Fixed the test, which was one of the primary failures to identify this as it was testing the path stitched together with the baseURL and uri.

Types of changes

Checklist:

codecov-commenter commented 1 year ago

Codecov Report

Merging #413 (aead0bb) into main (5d59b3f) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #413   +/-   ##
=========================================
  Coverage     77.60%   77.61%           
- Complexity     1962     1963    +1     
=========================================
  Files           191      191           
  Lines          5221     5223    +2     
=========================================
+ Hits           4052     4054    +2     
  Misses         1169     1169           
Impacted Files Coverage Δ
src/Client/APIResource.php 93.30% <100.00%> (+0.06%) :arrow_up:
src/Voice/Client.php 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more