scts is an optional property - Githubissues

Vonage / vonage-php-sdk-core

Vonage REST API client for PHP. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.

https://developer.vonage.com/

Apache License 2.0

916 stars 180 forks source link

scts is an optional property #424

Closed SecondeJK closed 1 year ago

SecondeJK commented 1 year ago

Small PR to make stcs optional, as this field sometimes does not return based on the carrier response.

Motivation and Context

The field not being optional right now stops the webhook object for delivery being successfully hydrated.

How Has This Been Tested?

All tests pass, no need to tweak them.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.