Vonage / vonage-php-sdk-core

Vonage REST API client for PHP. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
https://developer.vonage.com/
Apache License 2.0
916 stars 180 forks source link

Vonage server does not send network-code property in DeliveryReceipt JSON Payload #435

Closed repli2dev closed 11 months ago

repli2dev commented 1 year ago

Expected Behavior

DeliveryReceipt class should be able to construct the object for payloads that comes in Vonage webooks.

Current Behavior

Delivery Receipt missing required datanetwork-code` on this payload

{
"api-key": "<CENSORED>",
"err-code": "7",
"message-timestamp": "2023-09-10 23:20:37",
"messageId": "<UUID>",
"msisdn": "<CENSORED>",
"price": "0",
"scts": "23091012334",
"status": "failed",
"to": "<CENSORED>"
}

Possible Solution

Make the field optionally the same way as scts in #416

Steps to Reproduce (for bugs)

Attempt to create DeliveryReceipt object from above payload.

Context

Started od Monday 11 around midnight, we have like 60 of such issues per hour.

Your Environment

SecondeJK commented 11 months ago

Fixed in #438