Vonage / vonage-php-sdk-core

Vonage REST API client for PHP. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
https://developer.vonage.com/
Apache License 2.0
908 stars 181 forks source link

Refactor to JWT library #441

Closed SecondeJK closed 10 months ago

SecondeJK commented 10 months ago

This PR marks the first move to remove the dependency for lcobucci/jwt to vonage/jwt.

Description

While vonage/jwt still uses lcobucci/jwt under the hood, I am extracting it as a dependency for core so that the vonage/jwt library can firstly be reused for other projects that require vonage-specifc JWTs.

Motivation and Context

Preparing core for v5.0 by adjusting dependencies.

How Has This Been Tested?

Existing tests pass.

Example Output or Screenshots (if appropriate):

Types of changes

Checklist:

codecov-commenter commented 10 months ago

Codecov Report

Merging #441 (fdd9215) into main (9ebd564) will increase coverage by 0.04%. The diff coverage is 94.44%.

@@             Coverage Diff              @@
##               main     #441      +/-   ##
============================================
+ Coverage     78.87%   78.92%   +0.04%     
  Complexity     2324     2324              
============================================
  Files           218      218              
  Lines          6253     6248       -5     
============================================
- Hits           4932     4931       -1     
+ Misses         1321     1317       -4     
Files Coverage Δ
src/Client/Credentials/Keypair.php 91.17% <94.44%> (+9.12%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more