Closed erickskrauch closed 10 months ago
Merging #443 (5f63467) into main (9ebd564) will increase coverage by
0.04%
. Report is 1 commits behind head on main. The diff coverage is89.47%
.
@@ Coverage Diff @@
## main #443 +/- ##
============================================
+ Coverage 78.87% 78.92% +0.04%
Complexity 2324 2324
============================================
Files 218 218
Lines 6253 6248 -5
============================================
- Hits 4932 4931 -1
+ Misses 1321 1317 -4
Files | Coverage Δ | |
---|---|---|
src/Client/Credentials/Keypair.php | 91.17% <94.44%> (+9.12%) |
:arrow_up: |
src/Numbers/Number.php | 70.00% <0.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
LGTM, thank you for your contribution!
Description
When the number isn't linked to the application, there are no fields
voiceCallbackValue
andmessagesCallbackValue
, so callingNumber::getAppId()
produces an error on access to not existing array key.Motivation and Context
I need this functionality so I fix it.
How Has This Been Tested?
I tried it with my codebase.
Types of changes
Checklist: