Closed erickskrauch closed 10 months ago
In order to bump jwt to 5.0, it needs to happen here as this is the new dependency: https://github.com/Vonage/vonage-php-jwt
I can open it there soon. Regarding JWT being on this project, that's only for backwards compatibility and will be removed as a dependency in the next major version (5)
@SecondeJK, you can take a look on my PR for your JWT wrapper library :) Anyway, I think this PR must be merged because there is no available beta for a major update of this library, which can be offered to your customers (which I'm). So it will happen somewhere in the future with no defined ETA. You just limit your customers with legacy dependencies with no other option. My PR removes that limitation and allows us to use both versions of the library until the older version is dropped in the next major update.
So once again: there is no alternative at the current moment and thus this PR needs to be applied.
Description
After merging https://github.com/Vonage/vonage-php-sdk-core/pull/441 there is no reason not to allow v5 of
lcobucci/jwt
.Motivation and Context
I still need v5 of that library on my project :)
How Has This Been Tested?
Yes.
Types of changes
Checklist: