Vonage / vonage-php-sdk-core

Vonage REST API client for PHP. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
https://developer.vonage.com/
Apache License 2.0
908 stars 181 forks source link

Fix async behavior of the NCCO record action #446

Closed erickskrauch closed 2 weeks ago

erickskrauch commented 10 months ago

Description

As described in the documentation, the record action is asynchronous by default, unless it has endOnSilence, timeOut or endOnKey params. The current implementation of the Record action in this library provides no way to not specify that param.

Motivation and Context

We need to achieve an async behavior of the record action.

How Has This Been Tested?

We have made calls with those changes.

Example Output or Screenshots (if appropriate):

Call CON-b4cc19a0-ffd7-4e44-80ec-2d7ecf05c44c.

Types of changes

Checklist:

SecondeJK commented 10 months ago

This can be merged when it is time to release 5.0.0 (as although it's a fix, it's a semver breaking change in line with how the Record NCCO works currently)

SecondeJK commented 2 weeks ago

I've just picked up an internal ticket and fixed this in a different PR, although the solution seems to be much the same. Thanks for opening it though! #493