Vonage / vonage-php-sdk-core

Vonage REST API client for PHP. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
https://developer.vonage.com/
Apache License 2.0
908 stars 181 forks source link

remove verification checks, API behaviour too unstable currently #449

Closed SecondeJK closed 10 months ago

SecondeJK commented 10 months ago

This PR removes the server-side SDK check for supported locales on the basis that the Verify V2 API currently has some unexpected behaviour.

Description

You now supply a locale - if you don't, en-us is chosen. At the time of writing, the Vonage API will scan the to field in a workflow and choose your locale for you.

Motivation and Context

Attempt to get some consistency - right now, the emphasis here is for the API to handle error handling rather than the SDK to do it at the time of execution (before a call is made)

How Has This Been Tested?

Test to make sure you can give a valid locale has been removed.

Example Output or Screenshots (if appropriate):

Types of changes

Checklist:

codecov-commenter commented 10 months ago

Codecov Report

Merging #449 (a1af21a) into main (c598f9b) will decrease coverage by 0.01%. Report is 1 commits behind head on main. The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #449      +/-   ##
============================================
- Coverage     78.92%   78.91%   -0.01%     
+ Complexity     2324     2323       -1     
============================================
  Files           218      218              
  Lines          6248     6246       -2     
============================================
- Hits           4931     4929       -2     
  Misses         1317     1317              
Files Coverage Δ
src/Verify2/VerifyObjects/VerificationLocale.php 50.00% <ø> (-12.50%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more