Vonage / vonage-php-sdk-core

Vonage REST API client for PHP. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
https://developer.vonage.com/
Apache License 2.0
908 stars 181 forks source link

Remove superfluous code, push change to default sender ID #453

Closed SecondeJK closed 9 months ago

SecondeJK commented 9 months ago

Change of default SenderID for Verify (legacy).

Description

UK Based carrier BT no longer accepts "verify" as a sender ID, as it is now a reserved keyword.

Motivation and Context

Bug fix.

How Has This Been Tested?

All tests pass

Example Output or Screenshots (if appropriate):

Types of changes

Checklist:

codecov-commenter commented 9 months ago

Codecov Report

Merging #453 (8d84d5d) into main (915a62f) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #453   +/-   ##
=========================================
  Coverage     78.94%   78.94%           
  Complexity     2331     2331           
=========================================
  Files           218      218           
  Lines          6264     6264           
=========================================
  Hits           4945     4945           
  Misses         1319     1319           
Files Coverage Δ
src/Verify/Request.php 64.63% <ø> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!