Closed deleugpn closed 8 months ago
We are currently waiting on some updates for Prophecy to make it's way through their libraries (Prophecy has a patch, was waiting for official 8.3 release, and then the phpunit-prophecy bridge should update). Once those are updated we'll be able to update our library officially to 8.3.
I updated the testing matrix in this PR to also drag in 8.3, so we can re-run and merge this once the underlying libraries are updated.
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
bac6ebc
) 78.94% compared to head (2695093
) 79.01%. Report is 2 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/Verify2/VerifyObjects/VerificationWorkflow.php | 75.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
hey @dragonmantank I just ran all tests on my local machine against PHP 8.3.0 and tests are passing.
Could you please approve the workflow and let me know what else we need to unlock this? I would like to update my project and Vonage is the only pending dependency not supporting PHP 8.3 yet.
I've approved the run, but not looked if prophecy is updated. I suspect we're close to merging this.
OK let's go.
Description
Support PHP 8.3
Motivation and Context
Use new PHP version
How Has This Been Tested?
It hasn't yet, hopefully the pull request will trigger automation tests.
Example Output or Screenshots (if appropriate):
Types of changes
Checklist: