Support PHP 8.3 - Githubissues

Vonage / vonage-php-sdk-core

Vonage REST API client for PHP. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.

https://developer.vonage.com/

Apache License 2.0

908 stars 181 forks source link

Support PHP 8.3 #455

Closed deleugpn closed 8 months ago

deleugpn commented 9 months ago

Description

Support PHP 8.3

Motivation and Context

Use new PHP version

How Has This Been Tested?

It hasn't yet, hopefully the pull request will trigger automation tests.

Example Output or Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Basic version maintenance

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

dragonmantank commented 9 months ago

We are currently waiting on some updates for Prophecy to make it's way through their libraries (Prophecy has a patch, was waiting for official 8.3 release, and then the phpunit-prophecy bridge should update). Once those are updated we'll be able to update our library officially to 8.3.

I updated the testing matrix in this PR to also drag in 8.3, so we can re-run and merge this once the underlying libraries are updated.

codecov-commenter commented 8 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bac6ebc) 78.94% compared to head (2695093) 79.01%. Report is 2 commits behind head on main.

Files	Patch %	Lines
src/Verify2/VerifyObjects/VerificationWorkflow.php	75.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #455 +/- ## ============================================ + Coverage 78.94% 79.01% +0.07% - Complexity 2331 2337 +6 ============================================ Files 218 218 Lines 6264 6281 +17 ============================================ + Hits 4945 4963 +18 + Misses 1319 1318 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

deleugpn commented 8 months ago

hey @dragonmantank I just ran all tests on my local machine against PHP 8.3.0 and tests are passing.

Could you please approve the workflow and let me know what else we need to unlock this? I would like to update my project and Vonage is the only pending dependency not supporting PHP 8.3 yet.

SecondeJK commented 8 months ago

I've approved the run, but not looked if prophecy is updated. I suspect we're close to merging this.

SecondeJK commented 8 months ago

OK let's go.