Vonage / vonage-php-sdk-core

Vonage REST API client for PHP. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
https://developer.vonage.com/
Apache License 2.0
908 stars 181 forks source link

From can now be added for sender_id on Verify2 SMS #461

Closed SecondeJK closed 8 months ago

SecondeJK commented 8 months ago

Description

This patch adds from as a field for Verify2 SMS

Motivation and Context

Sender_ID parity requirements with Verify legacy

How Has This Been Tested?

existing tests modified to check it gets sent out in the request

Example Output or Screenshots (if appropriate):

Types of changes

Checklist:

codecov-commenter commented 8 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bac6ebc) 78.94% compared to head (2861f85) 77.95%. Report is 2 commits behind head on main.

Files Patch % Lines
src/Verify2/VerifyObjects/VerificationWorkflow.php 75.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #461 +/- ## ============================================ - Coverage 78.94% 77.95% -0.99% - Complexity 2331 2382 +51 ============================================ Files 218 218 Lines 6264 6397 +133 ============================================ + Hits 4945 4987 +42 - Misses 1319 1410 +91 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.