Closed ryan-mend closed 6 months ago
@SecondeJK Curious as to what the plan here is?
The plan is to look into this, which is why it has been labelled with work-scheduled
:)
@SecondeJK Understood. I apologize for the confusion. I misunderstood what work-scheduled
meant. My assumption was that it meant we know what we want to do just haven't done it yet. Thank you for the update.
Hi @ryan-mend, just picking this up now. With regards to the implementation, it's clearly not right so I'll be be tinkering with the internals of the Client to get responses out. The dashboard UI tester is clearly configured here in a different way to the SDK where it knows what status will be charged and which will not, so I'll check these details.
I've also tested this to see if a charge is invoked with a 43 or 44 status and you're correct, it is still charged which is definitely a bug that needs fixing in the SDK.
Fixed by #466, release coming shortly. Thanks for reporting this @ryan-mend, calls with partial status codes can now be retrieved.
@SecondeJK Any chance you could make the same change to older versions of the sdk? We're currently forced to use no later version than 2.3 or 2.4 due to our version of php (7.3)?
Sorry, this is something that I wouldn't do unless you submitted a PR for it. PHP7.3 was EOL with security support stopping 2 years ago so it's advocating against best security practise essentially
We've noticed that on the Vonage API Dashboard there lies a link to take you to a
Getting started with Number Insight
page here.When we enter this number (18104967360) into the![image](https://github.com/Vonage/vonage-php-sdk-core/assets/80841665/485d8941-84fa-43f4-b90d-57ea7722e7c8)
Getting started with Number Insight
page and press theLook up number
button, the look up appears to succeed and this gets displayed on the page:However when trying to look that same number (18104967360) up via this SDK, because the status code coming back in the look up response is
44
(non-zero) an exception is thrown and the response is obfuscated from the consuming application. This behavior seems consistent in all versions of this SDK.This leads me to a few questions/concerns:
https://github.com/Vonage/vonage-php-sdk-core/blob/28e056625c7c82a3a20fd13a91af396107afdcf9/src/Insights/Client.php#L119